Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more generic frontend module #39

Merged
merged 16 commits into from
Nov 20, 2023
Merged

Add more generic frontend module #39

merged 16 commits into from
Nov 20, 2023

Conversation

Judyxujj
Copy link
Contributor

This PR extends the VGG4LayerActFrontendV1 to enable more generic frontend. The activation functions, convolution layers and pooling layers can be differently combined in a customised way.

@christophmluscher
Copy link
Contributor

christophmluscher commented Oct 20, 2023

The generic frontend makes PR #33 obsolete since we have a more generic and flexible frontend available

@christophmluscher
Copy link
Contributor

christophmluscher commented Oct 20, 2023

@Judyxujj maybe you could add a note to the VGG4LayerActFrontendV1 suggesting to use the more generic version?

i6_models/parts/frontend/generic_frontend.py Outdated Show resolved Hide resolved
i6_models/parts/frontend/generic_frontend.py Outdated Show resolved Hide resolved
i6_models/parts/frontend/generic_frontend.py Outdated Show resolved Hide resolved
i6_models/parts/frontend/generic_frontend.py Outdated Show resolved Hide resolved
i6_models/parts/frontend/generic_frontend.py Outdated Show resolved Hide resolved
i6_models/parts/frontend/generic_frontend.py Outdated Show resolved Hide resolved
i6_models/parts/frontend/generic_frontend.py Outdated Show resolved Hide resolved
tests/test_generic_frontend.py Outdated Show resolved Hide resolved
tests/test_generic_frontend.py Outdated Show resolved Hide resolved
tests/test_generic_frontend.py Outdated Show resolved Hide resolved
@Judyxujj Judyxujj marked this pull request as draft November 10, 2023 14:36
@Judyxujj Judyxujj marked this pull request as ready for review November 10, 2023 15:07
@Judyxujj Judyxujj requested a review from SimBe195 November 10, 2023 15:07
@curufinwe curufinwe changed the title Jing generic frontend Add more generic frontend module Nov 16, 2023
@curufinwe curufinwe merged commit e170dcd into main Nov 20, 2023
2 checks passed
@albertz albertz deleted the jing-generic-frontend branch April 26, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants